Allow to instruct the client to save a document. #6848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
LSP
MartinBalin
approved these changes
Dec 15, 2023
lahodaj
approved these changes
Dec 15, 2023
| @@ -292,6 +300,7 @@ export namespace NodeInfoRequest { | |||
| } | |||
| }; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Nit: maybe remove this extra new line?
sdedic
force-pushed
the
lsp/client-save-document
branch
from
1f3eeb7 to
fae07f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LSP client can be instructed to perform edits on certain files, but NBLS may need to force the client to commit its bufers to disk - in particular if the project build / metadata files are modified, so it can reload the up-to-date project state.
The message that forces the client to save the document is missing from the official LSP protocol. This PR adds a
window/saveDocumentrequest that instructs the client to save specified documents.