Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish configured GSON in request's Lookup #6847

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented Dec 14, 2023

The LSP server implementation allows to configure GSON serializer used by lsp4j using @GsonSetup, but keeps the configured GSON private. This PR allows to lookup the configured GSON instance, so that command parameters may be serialized / deserialized using custom structure serializers injected b @GsonSetup.

@sdedic sdedic added the VSCode Extension [ci] enable VSCode Extension tests label Dec 14, 2023
@sdedic sdedic added this to the NB21 milestone Dec 14, 2023
@sdedic sdedic self-assigned this Dec 14, 2023
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@sdedic sdedic merged commit baa0a23 into apache:master Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants