Disable ANSI decorations for default (embedded) maven logger.

[mbien]

maven-slf4j-provider injects MavenSimpleLogger which decorates the output for terminal use. This causes problems in log files, tests etc which don't expect or cant display them properly.

a quick way to test this:
run NexusRepositoryIndexerImplTest#testFilterPluginGroupIdsRepositoryQueries directly from NB and check that there is no color in the stack trace. The TEST-org.netbeans.modules.maven.indexer.NexusRepositoryIndexerImplTest.xml should also have no escaped ANSI symbols in it.

long way to test would be to run NB and check that the log file is clean.
this is how it should not look:

[sdedic]

A question: I understand it is desirable to disable ansi output for testing, but wouldn't it affect some IDE operations that use Embedder ? Would it be possible to disable the coloring conditionally (i.e. some system property set up by the test infrastructure) ?

[mbien]

@sdedic I convert this back to draft since this trick isn't working anymore today for some reason. (can't explain it, i swear it worked yesterday)

But regarding what is affected: the messags.log is ansi decorated too, the screenshot above is the log opened with my default text editor on linux (xed) - it doesn't look much better when opened in NB. This creates a mess when pasted into issue forms etc.

edit:
the build output in the output window is not affected since 1) maven builds run outside of the IDE and 2) the output window itself does the parsing/coloring/linking etc.

[mbien]

thats likely the best way to be 100% sure that it is working:
here is the maven code:

https://github.com/apache/maven/blob/3c65873b584945c034aeb4ba51a5793c6582b19d/maven-embedder/src/main/java/org/apache/maven/cli/jansi/MessageUtils.java#L52-L61

[sdedic]

Great !!