Added go to test ability for test/tested class in lsp server #6834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Java
sdedic
requested changes
Jan 5, 2024
ide/gototest/src/org/netbeans/api/gototest/TestOppositesLocator.java
Outdated
Show resolved
Hide resolved
ide/gototest/src/org/netbeans/api/gototest/TestOppositesLocator.java
Outdated
Show resolved
Hide resolved
ide/gototest/src/org/netbeans/api/gototest/TestOppositesLocator.java
Outdated
Show resolved
Hide resolved
| } else { | ||
| TestLocator.LocationResult opposite = locator.findOpposite(fo, caretOffset); | ||
|
|
||
| if (opposite != null) { |
There was a problem hiding this comment.
Share this block of code with the asynchronous variant, if possible.
ide/gototest/src/org/netbeans/api/gototest/TestOppositesLocator.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private TestLocator.FileType getFileType(FileObject fo) { | ||
| TestLocator locator = getLocatorFor(fo); |
There was a problem hiding this comment.
This is a little strange: while populateLocationResults considers all locators. this implementation accepts the first result.
ide/gototest/src/org/netbeans/api/gototest/TestOppositesLocator.java
Outdated
Show resolved
Hide resolved
.../java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/WorkspaceServiceImpl.java
Outdated
Show resolved
Hide resolved
Achal1607
force-pushed
the
javavscode-56
branch
from
34f6ec7 to
4453667
Compare
sdedic
reviewed
Jan 11, 2024
ide/gototest/src/org/netbeans/api/gototest/TestOppositesLocator.java
Outdated
Show resolved
Hide resolved
Achal1607
force-pushed
the
javavscode-56
branch
from
4453667 to
33b1e4c
Compare
sdedic
reviewed
Jan 19, 2024
...p.server/src/org/netbeans/modules/java/lsp/server/commands/TestOppositesCommandProvider.java
Outdated
Show resolved
Hide resolved
...p.server/src/org/netbeans/modules/java/lsp/server/commands/TestOppositesCommandProvider.java
Outdated
Show resolved
Hide resolved
...p.server/src/org/netbeans/modules/java/lsp/server/commands/TestOppositesCommandProvider.java
Outdated
Show resolved
Hide resolved
|
Tried to address all the comments. |
|
The failing test is showing that it failed because it was unable to download artifacts, so can someone trigger tests for this again pls? |
sdedic
reviewed
Apr 15, 2024
ide/gototest/src/org/netbeans/api/gototest/TestOppositesLocator.java
Outdated
Show resolved
Hide resolved
ide/gototest/src/org/netbeans/api/gototest/TestOppositesLocator.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| if (opposites.getErrorMessage() != null) { | ||
| StatusDisplayer.getDefault().setStatusText(opposites.getErrorMessage()); |
There was a problem hiding this comment.
Can the execution reach here in headless mode ? If so, I would skip the dialog.
There was a problem hiding this comment.
I am afraid it won't be possible most probably.
Signed-off-by: Achal Talati <achal.talati@oracle.com>
Achal1607
force-pushed
the
javavscode-56
branch
from
1705aca to
211054b
Compare
sdedic
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netbeans IDE provided navigation option from test file to source file and vice versa, but this option was not present in the java extensions that use netbeans java lsp server. So, created an api module in
gototestlibrary which in turn is used by java lsp server for implementinggo to testfeature.refer to javavscode-56 for more info