PHP: Improve enum cases #6825
Merged
PHP: Improve enum cases #6825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add the `isBacked()` method to the `CaseElement` and the `EnumCaseElement` interfaces - Don't add values of non-backed enums to the code completion documentation - Index whether it is an enum case of a backed enum as a boolean value - Fix/Add unit tests - Increment spec version
tmysik
reviewed
Dec 10, 2023
| @@ -289,15 +341,41 @@ private void checkStatements(List<Statement> statements, EnumDeclaration node) { | |||
| incorrectEnumProperties.add((FieldsDeclaration) statement); | |||
| } else if (statement instanceof UseTraitStatement) { | |||
| useTraits.put(node, (UseTraitStatement) statement); | |||
| } else if (statement instanceof CaseDeclaration) { | |||
| checkCaseDeclaration((CaseDeclaration) statement, isBackedEnum); | |||
|
|
|||
There was a problem hiding this comment.
Nitpick: an extra empty line perhaps?
tmysik
reviewed
Dec 10, 2023
| incorrectNonBackedEnumCases.add(caseDeclaration); | ||
| } | ||
| } | ||
|
|
tmysik
reviewed
Dec 10, 2023
| } | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Nitpick:no empty line after this one.
tmysik
approved these changes
Dec 10, 2023
|
I'll fix them later. Thank you, Tomas! |
- Fix the `IncorrectEnumHintErorr`
- Cases of non-backed enum must not have a value (e.g. the following
is a fatal error: `enum NonBacked {case EXAMPLE = 1;}`)
- Cases of backed enum must have a value (e.g. the following is a
fatal error: `enum Backed: int {case EXAMPLE;}`)
- Add/Fix unit tests
There is an error in the following example because `case B = self::` is not a complete statement.
Thus, the result of parsing doesn't recognize the enum declaration.
This means that some features don't work correctly.
(e.g. The enum declaration doesn't exist in the navigator. The code completion doesn't work.)
```php
enum Example: int {
case A = 1;
case B = self::
}
```
To improve this, add the `ASTErrorExpression` as a result of an enum case initializer part.
- Fix the parser
- Add unit tests
junichi11
force-pushed
the
php-improve-enum-cases
branch
from
00870b5 to
52127d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the enum case icon
CC Light
Before:
After:
Navigator Light
Before:
After:
CC Dark
Before:
After:
Navigator Dark
After:
Before:
Improve the code completion documentation for enum cases
isBacked()method to theCaseElementand theEnumCaseElementinterfacesBefore:
After:
Check an initializer of an enum case
IncorrectEnumHintErorris a fatal error:
enum NonBacked {case EXAMPLE = 1;})fatal error:
enum Backed: int {case EXAMPLE;})Before:
After:
Improve the code completion for enum cases
There is an error in the following example because
case B = self::is not a complete statement.Thus, the result of parsing doesn't recognize the enum declaration.
This means that some features don't work correctly.
(e.g. The enum declaration doesn't exist in the navigator. The code completion doesn't work.)
To improve this, add the
ASTErrorExpressionas a result of an enum case initializer part.Before:
After: