Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect JPA provider on classpath, removing requirement to have it as legacy library #6748

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Detect JPA provider on classpath, removing requirement to have it as legacy library #6748

merged 1 commit into from
Dec 9, 2023

Conversation

matthiasblaesing
Copy link
Contributor

In addition fixes typo in JPA 3.1 detection (duplicate ".class" suffix)

@matthiasblaesing
Detect JPA provider on classpath, removing requirement to have it as …
0a4be7b 
…legacy library

In addition fixes typo in JPA 3.1 detection (duplicate ".class" suffix)
@matthiasblaesing matthiasblaesing added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) enterprise [ci] enable enterprise job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Nov 24, 2023
@matthiasblaesing matthiasblaesing added this to the NB21 milestone Nov 24, 2023
@matthiasblaesing
Copy link
Contributor Author

I intent to merge this by next week, so if anyone wants to object, please do so now.

mbien
mbien approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@mbien mbien added the Java EE/Jakarta EE [ci] enable enterprise job label Nov 29, 2023
@matthiasblaesing
Copy link
Contributor Author

@mbien thanks for review!

@matthiasblaesing matthiasblaesing merged commit 1b075fe into apache:master Dec 9, 2023
@matthiasblaesing matthiasblaesing deleted the jpa_provider_on_classpath branch December 9, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien approved these changes

Assignees
No one assigned
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
NetBeans JavaEE related
Status: Done
Milestone
NB21
Development

Successfully merging this pull request may close these issues.
2 participants
@matthiasblaesing @mbien