Bump hardcoded maven compiler and resource plugin version defaults. #6681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused the build to fail when deprecation warnings were toggled via project properties UI, since the inserted maven compiler plugin is not compatible with current JDKs. At some point we should consolidate this and use the index, like already done in other places.
mbien
added
Maven
matthiasblaesing
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused the build to fail when deprecation warnings were toggled via maven project properties UI, since the inserted maven compiler plugin is not compatible with current JDKs.
At some point we should consolidate this and use the index, like already done in other places. But looking at the call hierarchy of the method this is too risky as last minute change IMO.