Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't scroll output window on link click. #6679

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

mbien
Copy link
Member

@mbien mbien commented Nov 9, 2023

  • adds another boolean to control if caret positioning should scroll (for sendCaretToPos and sendCaretToLine in AbstractOutputPane)
  • calls it with false on link clicks (in OutputTab:lineClicked), overloaded method default remains true
  • adds @Override to the hierarchy to be able to safely make changes. This also exposed duplicated/dead code which was removed
  • luckily its all internal API

run test snippet to create some links and click on them:

public class Mavenproject2 {
    public static void main(String[] args) {
        System.out.println(Runtime.version().major()); // <- linked deprecation warning
        throw new RuntimeException("click on stack"); // <- stack trace
    }
}

 - adds another boolean to control if caret positioning should scroll
 - calls it with false on link clicks, default remains true
 - adds override annotation to the hierarchy to be able to safely make
   changes. This also exposed duplicated/dead code which was removed
 - luckily its all internal API
@mbien mbien added Platform [ci] enable platform tests (platform/*) ci:all-tests [ci] enable all tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Nov 9, 2023
@mbien mbien added this to the NB20 milestone Nov 9, 2023
@apache apache locked and limited conversation to collaborators Nov 10, 2023
@apache apache unlocked this conversation Nov 10, 2023
Copy link
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and dev build seemed to behave as desired.

@neilcsmith-net neilcsmith-net merged commit 81ac164 into apache:delivery Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:all-tests [ci] enable all tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Platform [ci] enable platform tests (platform/*)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants