-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop horizontal scroll mouse button events on Linux #6644
Drop horizontal scroll mouse button events on Linux #6644
Conversation
Well, this could work. My only concern is that |
Funnily enough, my preference for handling here is partly simplicity, but also because I think it keeps the API as intended. The mapping of hardware button to OS button to JDK button to NB windows system button is in many ways an implementation detail. In future we could make this change optional or even allow other options in the window system without changing the API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree on this approach. Just thought that some additional documentation on the API would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me
98dc2d4
to
0e0560d
Compare
Thanks @lkishalmi Does the added implementation note documentation help? It's a bit weird to work out how best to document this, apart from being clear that doing this aligns with the intended API usage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thank you!
Drop horizontal scroll mouse button events on Linux to fix issues reported with trackpads triggering code navigation. The JDK already drops the X event button number by 2 to skip vertical scroll. This skips the horizontal scroll button values and drops the value another 2 before passing to the keymap, which should also bring Linux in line with other OS button values.
This is an alternative to #6636
Added a build for easier testing. Ideally we should check that Windows and macOS don't need the button 6&7 mappings anywhere.