PHP: Fix autocomplete for exception class when adding exception breakpoint. #6643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilcsmith-net
added
PHP
|
cc/ @junichi11 this is open against delivery so please could you review both the fix and the choice of branch (NB20 or NB21). Thanks! |
neilcsmith-net
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A qualified exception class name is required for the exception breakpoint to work correctly. The current implementation of autocomplete completes an unqualified exception class name.
Before:
simplescreenrecorder-2023-10-31_20.35.20.mp4
After:
simplescreenrecorder-2023-10-31_20.36.08.mp4