Navigate to Scala classes in Analyze Stack Window #6640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbalek
approved these changes
Oct 31, 2023
| @@ -60,8 +60,8 @@ class StackLineAnalyser { | |||
| "at\\s" + // initial at // NOI18N | |||
| "("+IDENTIFIER+"(?:\\."+IDENTIFIER+")*/)?" + // optional module name // NOI18N | |||
| "(("+IDENTIFIER+"(\\."+IDENTIFIER+")*)\\.)?("+IDENTIFIER+")" + // class name // NOI18N | |||
| "\\.("+IDENTIFIER+"|\\<init\\>|\\<clinit\\>)\\((?:"+IDENTIFIER+"(?:\\."+IDENTIFIER+")*/)?" +IDENTIFIER+"\\.java" + // method and file name // NOI18N | |||
| "\\:([0-9]*)\\)"); // line number // NOI18N | |||
| "\\.("+IDENTIFIER+"|\\<init\\>|\\<clinit\\>)\\((?:"+IDENTIFIER+"(?:\\."+IDENTIFIER+")*/)?" +IDENTIFIER+"\\.?("+IDENTIFIER+ // method and file name // NOI18N | |||
There was a problem hiding this comment.
\\.? - why is dot before file name extension optional in the new line pattern?
There was a problem hiding this comment.
Some files may not have extension, was my thought.
There was a problem hiding this comment.
In such case whole \\.?("+IDENTIFIER+") should be optional IMHO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code base of my project is full of Scala classes. While analyzing stacktraces with Analyze Stack Window I'd like to jump not only to Java classes, but also to sources coming from other languages like Scala.
With this PR I can do that:
Btw. to reproduce the same picture one needs Enso 4 NetBeans plugin. Tested on revision 3d23c6a8d.