Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ASM from 9.5 to 9.6 #6597

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Update ASM from 9.5 to 9.6 #6597

merged 1 commit into from
Oct 21, 2023

Conversation

pepness
Copy link
Member

@pepness pepness commented Oct 20, 2023

NetBeans Module Notes:

  • Bump NetBeans project properties javac.source and javac.target to version 11

Library Notes:

  • Support for Java 22
  • Bug fixes:
    • 317991: Analyzer produces frames that have different locals than those detected by JRE bytecode verifier
    • 317995: Invalid stackmap generated when the instruction stream has new instruction after invokespecial to
    • 317998: Analyzer can fail to catch thrown exceptions
    • 318002: asm-analysis Frame allocates an array unnecessarily inside executeInvokeInsn
    • bug in CheckFrameAnalyzer with static methods

Testing:

  • Full build done
  • Verify successful execution of libraries and licenses Ant test
  • Verify successful execution of ant check-sigtests-release
  • Verify successful execution of ant -Dcluster.config=release commit-validation
  • Verify that the jars are located in netbeans_dir/platform/core/
  • Successfully test some projects

ASM Web Page
Release Notes

@pepness pepness added Upgrade Library Library (Dependency) Upgrade Platform [ci] enable platform tests (platform/*) labels Oct 20, 2023
@pepness pepness added this to the NB21 milestone Oct 20, 2023
@pepness pepness self-assigned this Oct 20, 2023
@mbien mbien added the ci:all-tests [ci] enable all tests label Oct 20, 2023
mbien
mbien reviewed Oct 20, 2023
View reviewed changes
platform/libs.asm/nbproject/project.properties Outdated
Comment on lines 19 to 20
javac.source=1.8
javac.source=11
javac.target=11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might cause problems since some tests are not ready yet for JDK 11, see #4904

i added the all-tests label since asm is used in many places - just to be sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will push the change to version 8 and see if the tests go green.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASM declares itself compatible with 1.5: https://asm.ow2.io/faq.html#Q14 so there is no need to change the versions.

matthiasblaesing
matthiasblaesing approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

@pepness pepness merged commit a5c96b7 into apache:master Oct 21, 2023
@mbien mbien mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien left review comments

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees

@pepness pepness

Labels
ci:all-tests [ci] enable all tests Platform [ci] enable platform tests (platform/*) Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Milestone
NB21
Development

Successfully merging this pull request may close these issues.
3 participants
@pepness @mbien @matthiasblaesing