Micronaut Template for Data repository - add support for Pageable #6591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thurka
added
LSP
MartinBalin
approved these changes
Oct 20, 2023
dbalek
approved these changes
Oct 23, 2023
| @@ -132,6 +139,14 @@ protected List<FileObject> createFromTemplate(CreateDescriptor desc) throws IOEx | |||
| DialogDisplayer.getDefault().notifyLater(new NotifyDescriptor.Message(Bundle.MSG_NoEntities(sourceGroup.getRootFolder().getPath()), NotifyDescriptor.ERROR_MESSAGE)); | |||
| return Collections.emptyList(); | |||
| } | |||
| List<Item> repoType = new ArrayList<>(); | |||
| Item pageableItem = new Item(Bundle.MSG_PageableRepository(), null /*Bundle.DESC_PageableRepository()*/); | |||
| repoType.add(new Item(Bundle.MSG_CrudRepository(), null /*Bundle.DESC_CrudRepository()*/)); | |||
There was a problem hiding this comment.
Why is the item's description commented out?
There was a problem hiding this comment.
It was there initially, but Jirka suggested to remove it, since it is too long and does not fit well in one line. We can use it as 'detail' string when Item is extended to support it - it currently supports name and description of QuickPickItem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Micronaut Template for Data repository only offers the ability to implement CrudRespoitory. We should offer the choice of implementing PageableRepository through the wizard.
A user is be able to choose if he wants the repository to be based on CRUD, or Pageable. The default is CRUD.