#6536, #6537: avoid stack overflow, catch missing artifacts to be downloaded. #6548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts to be downloaded.
sdedic
added
Java
MartinBalin
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've worked with Micronaut 4.1.x. The project is apparently configured differently than the previous version ... so other problems surfaced.
#6537 was caused by a
StackOverflowError- during dumping of complex structures, the traversal was not guarded against recursing through loop links inside the structure. This was fixed by noting the dumped instance in a Map and preventing the recursion if the dumper encounters that instance again.#6536 was more tricky - it seems that
getResolvedConfigurationand maybe other calls throwArtifactResolveExceptionfor artifacts not yet in the local cache. The exception was not caught / detected properly and was treated as a load error. Now the entire analysis is wrapped by a guard, that rethrows those exceptions asNeedOnlineModeException, handled by the project loader.