Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native execution binaries for macOS arm64 (1-24aefa9) #6521

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

neilcsmith-net
Copy link
Member

@neilcsmith-net neilcsmith-net commented Oct 3, 2023

Work-in-progress update to staged native execution binaries 1-reb9e96d with (some!) binaries for Apple Silicon. Built in workflow https://github.com/apache/netbeans/actions/runs/6395128403 This is a follow up to #6513 and part of addressing #3467 . It is enough to get the terminal support working, although other aspects might need additional work.

This PR is for testing and voting purposes. The native binaries must be voted on and moved to release, and this PR updated, before merging to master.

The previous binaries for all existing OS are kept in place at the moment, despite the staged artefact also including macOS and Linux x86_64.

UPDATE : updated to use the revised staged binaries 1-24aefa9

UPDATE : updated to use the released binaries 1-24aefa9

@neilcsmith-net neilcsmith-net added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Oct 3, 2023
@neilcsmith-net neilcsmith-net added this to the NB20 milestone Oct 3, 2023
@neilcsmith-net neilcsmith-net marked this pull request as draft October 3, 2023 16:25
@neilcsmith-net neilcsmith-net changed the title WIP Add native execution binaries for macOS arm64 (1-reb9e96d STAGED) WIP Add native execution binaries for macOS arm64 (1-24aefa9 STAGED) Oct 11, 2023
@neilcsmith-net neilcsmith-net changed the title WIP Add native execution binaries for macOS arm64 (1-24aefa9 STAGED) Add native execution binaries for macOS arm64 (1-24aefa9) Oct 14, 2023
@neilcsmith-net neilcsmith-net marked this pull request as ready for review October 14, 2023 09:40
@neilcsmith-net
Copy link
Member Author

Thanks @matthiasblaesing Updated to use the released artefacts. Should be ready to merge assuming all green.

Copy link
Contributor

@vieiro vieiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 https://archive.apache.org/dist/netbeans/native/netbeans-nativeexecution/1-24aefa9/nativeexecution-external-binaries-1-24aefa9.zip has sha512sum 429b5ada5be9bf02b6aaa3da94880296c4052e036e805c64d114ac3bbe47f057a1b19251904ec1fefc3c21a24b8dbf553bbc9813fe717b9f4c94caf2c585e7e5

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants