Update bouncycastle to jdk18on-1.76.

[mbien]

• switches from jdk15on to jdk18on (which is for JDK 8+, see page)
• updates from 1.70 to 1.76

we might need this update for #6500, lets see if everything is green

[matthiasblaesing]

Looks sane to me. Thank you.

[mbien]

@matthiasblaesing the lib wrappers here don't expose any packages:

netbeans/ide/bcpg/nbproject/project.xml

Lines 24 to 34 in 2cb4326

	<configuration>
	<data xmlns="http://www.netbeans.org/ns/nb-module-project/2">
	<code-name-base>bcpg</code-name-base>
	<module-dependencies/>
	<public-packages/>
	<class-path-extension>
	<runtime-relative-path>bcpg.jar</runtime-relative-path>
	<binary-origin>external/bcpg-jdk18on-1.76.jar</binary-origin>
	</class-path-extension>
	</data>
	</configuration>

how does this work at runtime? Shouldn't this be <friend-packages> or shared via impl dependency?

[matthiasblaesing]

The important part is here:

netbeans/ide/bcpg/nbproject/project.properties

Line 17 in 2cb4326

release.external/bcpg-jdk18on-1.76.jar=modules/bcpg.jar

This copies the bouncy castle PGP implementation into the modules folder of the corresponding cluster. In this case that is ide/modules. The important part is, that the library is an OSGI jar and that is picked up by the module system. So the "project" in the netbeans sources only exists as a place holder, the only interesting part is the copy operation. The build process itself is deactivated (the jar target is overwritten with an empty implementation):

netbeans/ide/bcpg/build.xml

Line 20 in 2cb4326

<target name="jar"/>

At least that is my understanding.

[mbien]

thanks for the help - much appreciated.