Removed a few defunct Gradle Settings #6516
Conversation
extide/gradle/apichanges.xml
Outdated
| <version major="2" minor="36"/> | ||
| <date day="2" month="10" year="2023"/> | ||
| <author login="lkishalmi"/> | ||
| <compatibility semantic="compatible" /> |
There was a problem hiding this comment.
IMHO semantic should be incompatible: code that hopes the setter (setting) has some effect may break.
| * @param b | ||
| * @deprecated | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Consider to log a WARNING-level message in the setters.
|
wanted to merge but seeing two unresolved reviewer comments, freeze is on the 17th. |
|
I've started to work on removing the Grade version selector and adding a default java runtime instead. I hope I can submit that work on this branch tomorrow. |
|
Further cleanup, removed the option to select the Gradle version, added default Java Runtime selection for Gradle execution. There could be further enhancements, around warnings and auto selecting the proper JDK for Gradle Execution, but this is how far I could go before NB20 window closes. |
|
as discussed on apache slack, going to add a commit which fixes some minor layout issues. Some show up right away, some are only visible when the window is resized: |
mbien
added
the
ci:dev-build
- consistent gaps between components and resize behavior - checked anchoring, editable state etc mostly in project properties and global gradle settings.
mbien
force-pushed
the
deprecate-a-few-gradle-setting
branch
from
b4f1364 to
0d84dd2
Compare
Removed the following no-more useful Settings from Gradle:
In the early days (2.x,3.x) it could have saved a few seconds, by loading the Daemon early, however in those days the Wrapper was not commonly used. Usually every project were used with one Gradle version set in the IDE. Project loading was also done by that daemon. Today, there is no advantage to fire up a Gradle Daemon which most likely won't be used.
It started to download a new Gradle version when it was selected in the settings dialog right when the dialog settings were applied. It could save a few seconds in the old days. Today it is usually done by the wrapper, and the project trust replaced this functionality.
In the older days, this was a real performance boost working on projects. Right now the flag state is, I'd say undecided. It got removed in
Gradle 8.0without deprecation, got restored inGradle 8.0.1. There is no sigh of deprecation since then. We put it in deprecated on NB18 for the option removal in NB20. It still can be used if someone overwrite the Gradle actions, but it's better to leave this option out.