Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TreeShims mechanism. #6495

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Remove TreeShims mechanism. #6495

merged 1 commit into from
Oct 10, 2023

Conversation

mbien
Copy link
Member

@mbien mbien commented Sep 27, 2023

The class is mostly empty at this point and was copied around using an annotation processor.

TreeShims.java was copied to:

./java/java.completion/build/classes-generated/org/netbeans/modules/java/completion/impl
./java/java.editor.base/build/classes-generated/org/netbeans/modules/java/editor/base/semantic
./java/java.editor/build/classes-generated/org/netbeans/modules/editor/java
./java/java.hints/build/classes-generated/org/netbeans/modules/java/hints

The class was mostly empty at this point and was copied
around using an annotation processor.
@mbien mbien added Code cleanup Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) labels Sep 27, 2023
@mbien mbien added this to the NB20 milestone Sep 27, 2023
@mbien mbien requested review from dbalek and lahodaj September 27, 2023 04:33
@mbien mbien marked this pull request as ready for review September 27, 2023 05:56
@mbien mbien requested review from sdedic and MartinBalin October 2, 2023 19:20
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

At some point, we should try to get rid of the reflection in java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToSwitchPatternInstanceOf.java, but the proposed state is not conceptually worse than the existing state, so no problem with the proposed state.

@mbien mbien merged commit 1c9eeab into apache:master Oct 10, 2023
@mbien
Copy link
Member Author

mbien commented Oct 10, 2023

thanks for the review! I did look at the reflection snippet at first but didn't want to change too much here (I also don't have much experience with the javac API), the code is copied from the TreeShims class almost unmodified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code cleanup Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants