Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disaplay parameter tooltips for annotations. #6487

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

dbalek
Copy link
Contributor

@dbalek dbalek commented Sep 25, 2023

Parameter tooltips (signature help in LSP) should be displayed also for annotations (in addition to method/constructor invocations).

@dbalek dbalek added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels Sep 25, 2023
@dbalek dbalek added this to the NB20 milestone Sep 25, 2023
@dbalek dbalek self-assigned this Sep 25, 2023
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests would be nice. Also a nit - there's a typo in the commit message: "Dispalay" -> "Display".

@dbalek dbalek merged commit afc33f3 into apache:master Sep 26, 2023
@dbalek dbalek deleted the dbalek/parameter-hints-on-annotations branch September 26, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants