Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed gap between checkboxes in php project testing settings #6381

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Fixed gap between checkboxes in php project testing settings #6381

merged 1 commit into from
Aug 29, 2023

Conversation

troizet
Copy link
Collaborator

@troizet troizet commented Aug 28, 2023

before:
before

after:
after

@mbien mbien added PHP [ci] enable extra PHP tests (php/php.editor) UI User Interface labels Aug 28, 2023
@mbien mbien added this to the NB20 milestone Aug 28, 2023
mbien
mbien approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good change, thanks!

@junichi11 junichi11 requested a review from tmysik August 28, 2023 22:56
tmysik
tmysik approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@tmysik tmysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to look into the code to actually see the fix 😅 Thanks!

junichi11
junichi11 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@junichi11 junichi11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merging.

@junichi11 junichi11 merged commit 28d308b into apache:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien approved these changes

@tmysik tmysik tmysik approved these changes

@junichi11 junichi11 junichi11 approved these changes

Assignees
No one assigned
Labels
PHP [ci] enable extra PHP tests (php/php.editor) UI User Interface
Projects
None yet
Milestone
NB20
Development

Successfully merging this pull request may close these issues.
4 participants
@troizet @mbien @tmysik @junichi11