Add nb-javac libwrapper tests. #6308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test min javac version requirement check - test module description Should make it less likely that version increments are overlooked during javac lib wrapper updates.
mbien
added
Java
mbien
commented
Aug 7, 2023
Comment on lines
+23
to
+25
|
|
||
| # for tests | ||
| requires.nb.javac=true |
There was a problem hiding this comment.
this seems to be working fine, feared it might be a chicken and egg problem. The module doesn't have any source code so I don't think this can have any side effects.
|
the very first run had a timeout in I hope its CI gremlins since I can't see how this PR could cause this. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make it less likely that version increments are overlooked during javac lib wrapper updates (e.g #6206 (comment)).