Start running enterprise tests on JDK 11 #6296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
CI
Not all are compatible yet, but this should not stop us from running those who are on JDK 11.
mbien
force-pushed
the
ci-enterprise-more-on-11
branch
from
59e99f0 to
2afb362
Compare
mbien
commented
Aug 4, 2023
Comment on lines
-103
to
-109
| public void testGetAppDDRoot() throws FileNotFoundException, IOException, SAXException { | ||
| public void fails_testGetAppDDRoot() throws FileNotFoundException, IOException, SAXException { | ||
| File[] list = getDataDir().listFiles(); | ||
| if (null == list || list.length == 0) | ||
| return; | ||
| SunApplication root = null; | ||
| for (File fo : list) { | ||
| if (fo.getName().startsWith("valid-sun-application")) { | ||
| InputStream is = null; |
There was a problem hiding this comment.
fyi: those two test cases did pass even though the if-block never matched anything. Essentially a false positive.
fixed the tests and turned two of them off
|
|
matthiasblaesing
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all are compatible yet, but this should not stop us from running those who are on JDK 11.
followup on #6244