Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update dialog parent API, displayer impl and test." #6291

Closed
wants to merge 1 commit into from
Closed

Revert "Update dialog parent API, displayer impl and test." #6291

wants to merge 1 commit into from

Conversation

neilcsmith-net
Copy link
Member

@neilcsmith-net neilcsmith-net commented Aug 3, 2023 •
edited
Loading

Revert option for #6216 due to issue #6290

Possible alternative is #6294 but may be less risky to revert for NB19?

@neilcsmith-net
Revert "Update dialog parent API, displayer impl and test."
340e33e 
This reverts commit d7474cf.

Revert "apache#5987: Use the currently active dialog as the presenter parent."

This reverts commit d1ac397.
@neilcsmith-net neilcsmith-net added do not merge Don't merge this PR, it is not ready or just demonstration purposes. Platform [ci] enable platform tests (platform/*) ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Aug 3, 2023
@neilcsmith-net neilcsmith-net added this to the NB19 milestone Aug 3, 2023
@neilcsmith-net neilcsmith-net mentioned this pull request Aug 3, 2023
Merged
@neilcsmith-net
Copy link
Member Author

OK, closing in favour of the fix option in 19-rc4.

@neilcsmith-net neilcsmith-net deleted the revert-gh6216 branch January 16, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien Awaiting requested review from mbien

@ebarboni ebarboni Awaiting requested review from ebarboni

@MartinBalin MartinBalin Awaiting requested review from MartinBalin

@sdedic sdedic Awaiting requested review from sdedic

Assignees
No one assigned
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) do not merge Don't merge this PR, it is not ready or just demonstration purposes. Platform [ci] enable platform tests (platform/*)
Projects
None yet
Milestone
NB19
Development

Successfully merging this pull request may close these issues.
1 participant
@neilcsmith-net