Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: Open sources from Jar files as read-only from their true locations. #6286

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

dbalek
Copy link
Contributor

@dbalek dbalek commented Aug 2, 2023

Sources from jar files should be opened as read-only preserving their true locations. There is no need to create temporary copies of these sources being opened any more.

@dbalek dbalek added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels Aug 2, 2023
@dbalek dbalek added this to the NB20 milestone Aug 2, 2023
@dbalek dbalek requested review from sdedic and lahodaj August 2, 2023 10:28
@dbalek dbalek self-assigned this Aug 2, 2023
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@dbalek dbalek merged commit 00bf962 into apache:master Aug 3, 2023
@dbalek dbalek deleted the dbalek/lsp-src-from-jars branch August 3, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants