Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark test methods as unused. #6277

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

dbalek
Copy link
Contributor

@dbalek dbalek commented Jul 31, 2023

JUnit test methods should not be marked as unused in editor.

@dbalek dbalek added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) VSCode Extension [ci] enable VSCode Extension tests labels Jul 31, 2023
@dbalek dbalek added this to the NB20 milestone Jul 31, 2023
@dbalek dbalek requested review from MartinBalin, sdedic and lahodaj July 31, 2023 13:44
@dbalek dbalek self-assigned this Jul 31, 2023
@dbalek dbalek force-pushed the dbalek/no-unused-test-methods branch from da79fdc to ee9e51e Compare August 2, 2023 13:01
@dbalek dbalek force-pushed the dbalek/no-unused-test-methods branch from ee9e51e to 6b8e152 Compare August 4, 2023 13:40
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@dbalek dbalek merged commit 35a3f16 into apache:master Aug 7, 2023
@dbalek dbalek deleted the dbalek/no-unused-test-methods branch August 7, 2023 07:25
@mbien
Copy link
Member

mbien commented Oct 13, 2023

@sdedic @dbalek does this PR close #6284?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hints Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants