Terminal input ignores detected encoding #6271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
approved these changes
Jul 29, 2023
BradWalker
approved these changes
Jul 29, 2023
It was observed that on a german windows installation with JDK 17 the terminal correctly shows german umlauts, but fails on input. The terminal subsystem has code to detect the charset used in the terminal. Investigation then leads to StreamTerm, where the InputStream for data coming from the terminal is adapted with the detected charset, while the user input is ran through an OutputStreamWriter without charset set. Therefore the user input is encoded with Cp1250 (default on german windows setups). This leads to garbled input. The fix applies the same logik, that is already applied to the InputStream, also to the OutputStream.
matthiasblaesing
force-pushed
the
inputencoding_terminal
branch
from
2598ba0 to
4a8a8d4
Compare
|
Cherry-picked onto delivery, changes base branch, added NB19 milestone. @BradWalker, @mbien thank you for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was observed that on a german windows installation with JDK 17 the terminal correctly shows german umlauts, but fails on input.
The terminal subsystem has code to detect the charset used in the terminal.
Investigation then leads to StreamTerm, where the InputStream for data coming from the terminal is adapted with the detected charset, while the user input is ran through an OutputStreamWriter without charset set. Therefore the user input is encoded with Cp1250 (default on german windows setups). This leads to garbled input.
The fix applies the same logik, that is already applied to the InputStream, also to the OutputStream.
Before:
After: