Supporting source file launcher in VS Code extension #6262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahodaj
added
the
Java
sdedic
reviewed
Jul 27, 2023
| if (!(argumentsObject instanceof String)) { | ||
| return null; | ||
| } | ||
| return Arrays.asList(((String) argumentsObject).trim().split(" ")); //NOI18N |
There was a problem hiding this comment.
Maybe handle possible escaping (`BaseUtilities.parseParameters ?)
| compileClassPathImplementation.setDelegates(spec2CP(classpath)); | ||
| compileModulePathImplementation.setDelegates(spec2CP(modulepath)); | ||
|
|
||
| System.err.println("compileClassPath: " + compileClassPath); |
| case "--module-path": case "-p": | ||
| modulepath = parameter; | ||
| break; | ||
| case "--source": |
There was a problem hiding this comment.
Thanks, but I don't think it should be here - these are source launcher options (as opposed to javac options), and source launcher does not support -source.
| String sourceLevel = SourceLevelResultImpl.DEFAULT_SL; | ||
|
|
||
| for (int i = 0; i < newOptions.size(); i++) { | ||
| if (i + 1 >= newOptions.size()) |
There was a problem hiding this comment.
Maybe limit the loop to just newOptions.size() -1 ?
| } | ||
|
|
||
| if (compilerArgs.contains(SOURCE_FLAG)) { | ||
| compilerArgs = m.replaceAll("--enable-preview " + SOURCE_FLAG + " " + realNewSourceLevel); |
There was a problem hiding this comment.
Use the constant ENABLE_PREVIEW_FLAG ?
|
This looks good, thank you for making this change! Appoved |
sdedic
approved these changes
Jul 31, 2023
lahodaj
force-pushed
the
source-launcher-in-lsp
branch
from
bc9417f to
42caa8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Single) source file launcher support has multiple problems inside VS Code - especially settings that are inside NetBeans done through file attributes are not accessible. This patch attempts to use the Run Configuration tab/settings to provide options for launching the single file. The same options are also parsed for use in the editor.
^Add meaningful description above
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.