-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set DB environment for java+ as well as for java #6248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to make 2 instances of DBConfigurationProvider
instead of using a global variable -- but it seems a matter of style here: none of the reloadable NBLS-related state is used.
@jhorvath only the release team should be merging to delivery. |
cc/ @mbien out of interest, when you were setting up branch protection, did you notice whether |
@neilcsmith-net sorry, I've suggested to Jan he should merge to delivery. |
@MartinBalin no worries - you're on it anyway. I'll be syncing for rc2 tomorrow morning, so unless there's anything urgent let's wait for both sync PRs before merging anything else. |
@neilcsmith-net I don't think this is possible. The doc at least does not list this as an option. edit: gh itself seems to be supporting it: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches#restrict-who-can-push-to-matching-branches going to ask on infra slack |
To correctly set environment variables for database connection we need to register DBConfigurationProvider for both targets - java+ and java.