Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable 'Rerun failed tests' button for JUnit5 #6217

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Enable 'Rerun failed tests' button for JUnit5 #6217

merged 1 commit into from
Jul 21, 2023

Conversation

Atrament666
Copy link

Fixes #6199

There was no support for JUnit5 in JUnitOutputListenerProvider in Maven Junit which resulted in the button to be always disabled.

@mbien mbien added the Maven [ci] enable "build tools" tests label Jul 18, 2023
@apache apache locked and limited conversation to collaborators Jul 18, 2023
@apache apache unlocked this conversation Jul 18, 2023
@neilcsmith-net neilcsmith-net changed the base branch from master to delivery July 18, 2023 16:04
@neilcsmith-net neilcsmith-net added this to the NB19 milestone Jul 18, 2023
@neilcsmith-net neilcsmith-net requested a review from mbien July 18, 2023 16:04
mbien
mbien reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@mbien mbien left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change makes sense to me - thanks!

This fix is fairly self contained and might be a candidate for NB 19 RC2. Going to retarget this pr to delivery and set the do-not-merge label just in case.

@mbien mbien added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Jul 18, 2023
@neilcsmith-net neilcsmith-net added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Jul 20, 2023
@apache apache locked and limited conversation to collaborators Jul 20, 2023
@apache apache unlocked this conversation Jul 20, 2023
@neilcsmith-net neilcsmith-net removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Jul 21, 2023
@neilcsmith-net
Copy link
Member

Change looks sane.

Did a quick test with the CI build - button doesn't work on the current project I'm working with in NB18, does with this change.

Thanks, merging to 19-rc2 - please double check when that's out.

@neilcsmith-net neilcsmith-net merged commit a4a6982 into apache:delivery Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien left review comments

Assignees
No one assigned
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Maven [ci] enable "build tools" tests
Projects
None yet
Milestone
NB19
Development

Successfully merging this pull request may close these issues.

Rerun failed tests button is not getting enabled
4 participants
@Atrament666 @neilcsmith-net @mbien @VladMachat