Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for a lazy computation of CodeAction edits. #6208

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

dbalek
Copy link
Contributor

@dbalek dbalek commented Jul 17, 2023

CodeAction edits could be computed lazily only when needed. This should speed up LSP server processing as most of the CodeAction edit computations require a modification task to be executed.

@dbalek dbalek added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels Jul 17, 2023
@dbalek dbalek added this to the NB19 milestone Jul 17, 2023
@dbalek dbalek requested review from jlahoda, MartinBalin and sdedic July 17, 2023 09:31
@dbalek dbalek self-assigned this Jul 17, 2023
Copy link
Contributor

@jlahoda jlahoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dbalek dbalek merged commit f49ef02 into apache:master Jul 17, 2023
@dbalek dbalek deleted the dbalek/lazy-code-actions branch July 17, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants