Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect AbstractClassInstantiationHintError #6119 #6171

Conversation

junichi11
Copy link
Member

Before:

nb-php-gh-6119-abstract-instantiation-hint-error-before

After:

nb-php-gh-6119-abstract-instantiation-hint-error-after

@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Jul 9, 2023
@junichi11 junichi11 added this to the NB19 milestone Jul 9, 2023
@junichi11 junichi11 requested a review from tmysik July 9, 2023 15:19
@junichi11 junichi11 linked an issue Jul 9, 2023 that may be closed by this pull request
@junichi11 junichi11 force-pushed the php-gh-6119-incorrect-abstract-instantiation-hint branch from a9f4666 to 4505a5b Compare July 9, 2023 23:47
@junichi11
Copy link
Member Author

@tmysik Thank you for your reviews and your time :)

- apache#6119
- Check whether the class name has `$`
- Add unit tests
@junichi11 junichi11 force-pushed the php-gh-6119-incorrect-abstract-instantiation-hint branch from 4505a5b to e8bf72e Compare July 10, 2023 09:23
@junichi11 junichi11 merged commit 3a61869 into apache:master Jul 10, 2023
@junichi11 junichi11 deleted the php-gh-6119-incorrect-abstract-instantiation-hint branch July 10, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP unspected "Abstract class MyClass cannot be instantiated"
2 participants