Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the PHP sample project for PHPUnit #6169

Merged

Conversation

junichi11
Copy link
Member

- Update the version to PHPUnit 10
- Remove the unavailable URL from readme.html
- Add setting for code coverage to readme.html
- Fix the phpunit.xml (the `filter` element is available no longer. Instead, use the `coverage` element.)
- See: https://docs.phpunit.de/en/10.1/configuration.html (https://phpunit.de/documentation.html)
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Jul 9, 2023
@junichi11 junichi11 added this to the NB19 milestone Jul 9, 2023
@junichi11 junichi11 requested a review from tmysik July 9, 2023 14:01
@junichi11 junichi11 merged commit e418ee1 into apache:master Jul 9, 2023
@junichi11 junichi11 deleted the php-update-php-sample-for-phpunit branch July 9, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants