Fix tab closing when trying to select partly clipped tab.

[neilcsmith-net]

Fix FlatEditorTabCellRenderer to not return close button bounds when clipped and not painting it. This seems to be the cause of #4738 and #6143

[eirikbakke]

Looks good, assuming you tested it before and after and confirmed that the bug was reproducible first and then disappeared once the patch was put in.

Thanks for fixing this! (I do see that bug in my own IDE!)

[neilcsmith-net]

Thanks @eirikbakke yes, of course. 😄 And stepped through with the debugger to see what was going on before and after the change. Been annoying me for a little while too.

[eirikbakke]

Yeah, I was just too lazy to build and test it myself :-)

[DevCharly]

Just tested. Fixes the issues for FlatLaf 👍

The same fix is needed for the Windows L&F here:

netbeans/platform/o.n.swing.tabcontrol/src/org/netbeans/swing/tabcontrol/plaf/WinFlatEditorTabCellRenderer.java

Line 169 in e5fb9c9

if (!ren.isShowCloseButton()) {

Also tested Nimbus and Metal, but they do not have the issue because they use different painters for clipped sided, which always return zero-size rectangle from TabPainter.getCloseButtonRectangle(). E.g. in class NimbusLeftClipPainter.

Aqua, GTK, WinVista, WinClassic and WinXP also have such painters for clipped sides.

[neilcsmith-net]

@DevCharly thanks, OK, done. I hadn't looked at any of the other implementations.

My main dev machine doesn't run Windows, and I might not be able to test there this week. I've added the ci:dev-build label. Could someone double check this is all good there before merge? Thanks!

[mbien]

this issue shows that not enough use the "group by project" setting :D
I was always confused by the issues since I couldn't reproduce this no matter how many pixels the button had on screen.

[DevCharly]

@mbien maybe you have enabled one of the options in following screenshot that are surrounded by red rectangles?
Then you're using multi-tabs implementation, which does not have this issue.
NetBeans has two implementations for tabs:

• tab control: only single-line on top edge (the default)
• multi-tabs: multi-line, top/bottom/left/right edges, ...

[mbien]

@DevCharly yes exactly. I have usually the bottom right checkbox enabled since I typically have many projects open at the same time.

[DevCharly]

Tested Windows L&F. Works 👍

[neilcsmith-net]

Thanks, merging.