Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for BigStringCustomEditor not being able to save Strings backed by byte arrays #6157

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

SirIntellegence
Copy link
Contributor

@SirIntellegence SirIntellegence commented Jul 5, 2023

I have also simplified some logic related to accessing the backing data. My light tests (of opening and debugging a Java app) passed.

@SirIntellegence
Copy link
Contributor Author

Right, issue link: #6147

@mbien mbien added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Jul 5, 2023
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. I recently ran into this problem and wanted to have a look.

If I understand it correctly you apply the same fix you did for the "view" implementation also to the "save" implementation and factor out the common code.

The approach looks ok to me and works. However, I think the wording and organisation could be improved. I left a few inline comments, please have a look. Thank you.

SirIntellegence added a commit to SirIntellegence/incubator-netbeans that referenced this pull request Jul 10, 2023
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I was able to verify, that his worked for Latin1 and UT-16 compact strings.

I'm down to stylistic comment (see inline), which is a good sidn. Basicly please add a bit of whitespace around the methods.

When this is done, please squash the commits into a single one, I'm willing to merge.

@SirIntellegence
Copy link
Contributor Author

One more possible quick check before squash? Or should I just squash?

@mbien mbien added this to the NB19 milestone Jul 13, 2023
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SirIntellegence sorry, got message to late. Looks sane to me now. Please squash and I'll merge.

@mbien
Copy link
Member

mbien commented Jul 17, 2023

going to squash and force push into this PR later unless someone is faster, since the deadline is today night UTC - would be a shame to miss out on it.

Co-authored-by: Matthias Bläsing <mblaesing@doppel-helix.eu>
@matthiasblaesing
Copy link
Contributor

@mbien thanks for stepping in. PRs are green. I checked, that the squash did not change the modfied file. Lets merge.

@matthiasblaesing matthiasblaesing merged commit a58c667 into apache:master Jul 17, 2023
@matthiasblaesing
Copy link
Contributor

Oh and of course @SirIntellegence thank you for caring enough to fix the issue ;-)

@SirIntellegence
Copy link
Contributor Author

Ah, right. Sorry. I got to squish XD. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
3 participants