Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong javac tree access for module information in modular maven project #6154

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Fix wrong javac tree access for module information in modular maven project #6154

merged 2 commits into from
Jul 7, 2023

Conversation

matthiasblaesing
Copy link
Contributor

I noticed, that the function "Add to Moduleinfo" that can be invoked on maven dependencies does not work. Checkin the code showed, that the access to the AST has to be updated to the current compiler interface.

screenshot

@matthiasblaesing
Fix wrong javac tree access for module information in modular maven p…
25347df 
…roject

I noticed, that the function "Add to Moduleinfo" that can be invoked on
maven dependencies does not work. Checkin the code showed, that the
access to the AST has to be updated to the current compiler interface.
@matthiasblaesing matthiasblaesing added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) nb-javac Run nb-javac integration tests labels Jul 5, 2023
@matthiasblaesing matthiasblaesing added this to the NB19 milestone Jul 5, 2023
@matthiasblaesing matthiasblaesing requested a review from jlahoda July 5, 2023 18:19
@mbien mbien added the Maven [ci] enable "build tools" tests label Jul 5, 2023
@mbien
Copy link
Member

mbien commented Jul 5, 2023

added maven label since the java/maven module is tested in the build tools job which is triggered by maven/gradle/ant/... labels.

neilcsmith-net
neilcsmith-net approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Fixed a couple of these myself a little while back (#4780 and #5668). Code search finds a couple of other getKind() == Tree.Kind.MODULE instances that should probably be looked at (separately). I should have done that before!

@matthiasblaesing
Copy link
Contributor Author

Thank you both for kicking in the right test and review.

@matthiasblaesing matthiasblaesing merged commit aaf846a into apache:master Jul 7, 2023
@matthiasblaesing matthiasblaesing deleted the maven_module_support branch July 12, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilcsmith-net neilcsmith-net neilcsmith-net approved these changes

@jlahoda jlahoda Awaiting requested review from jlahoda

Assignees
No one assigned
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Maven [ci] enable "build tools" tests nb-javac Run nb-javac integration tests
Projects
None yet
Milestone
NB19
Development

Successfully merging this pull request may close these issues.
3 participants
@matthiasblaesing @mbien @neilcsmith-net