Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting "Prefixing all code names of commands with 'nbls'.", as more time will be needed to discuss, validate the patch and adjust to it. #6114

Merged

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jun 22, 2023


^Add meaningful description above

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

…e time will be needed to discuss, validate the patch and adjust to it.
@lahodaj lahodaj changed the title iReverting "Prefixing all code names of commands with 'nbls'.", as more time will be needed to discuss, validate the patch and adjust to it. Reverting "Prefixing all code names of commands with 'nbls'.", as more time will be needed to discuss, validate the patch and adjust to it. Jun 22, 2023
@lahodaj lahodaj force-pushed the revert-lsp-server-generic-commands-settings branch from 9c28cf6 to 4847b62 Compare June 22, 2023 11:19
@lahodaj
Copy link
Contributor Author

lahodaj commented Jun 22, 2023

Done using:

git apply --reverse --cached /tmp/6015.diff
git commit

where /tmp/6015.diff is the patch from PR #6015.

@jlahoda jlahoda requested review from dbalek and sdedic June 22, 2023 11:24
@jlahoda jlahoda added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests labels Jun 22, 2023
Copy link
Member

@sdedic sdedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully OK.

@jlahoda jlahoda merged commit 98cecc0 into apache:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants