Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instanceof expression with casting #5933 #6092

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Fix instanceof expression with casting #5933 #6092

merged 1 commit into from
Jul 9, 2023

Conversation

junichi11
Copy link
Member 

// this is a valid syntax
$string = $a instanceof ((string) $test);

nb-php-gh-5933-instanceof-with-casting

@junichi11
Fix instanceof expression with casting apache#5933
e58243a 
- apache#5933
- Fix the grammar file
- Add unit tests

```php
// this is a valid syntax
$string = $a instanceof ((string) $test);
```
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Jun 19, 2023
@junichi11 junichi11 added this to the NB19 milestone Jun 19, 2023
@junichi11 junichi11 linked an issue Jun 19, 2023 that may be closed by this pull request
IDE finds an error if casting a variable in arrow function #5933
Closed
@junichi11 junichi11 requested a review from tmysik July 8, 2023 06:06
@junichi11 junichi11 merged commit 61a114a into apache:master Jul 9, 2023
@junichi11 junichi11 deleted the php-gh-5933-instanceof-with-cast branch July 9, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmysik tmysik tmysik approved these changes

Assignees
No one assigned
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB19
Development

Successfully merging this pull request may close these issues.

IDE finds an error if casting a variable in arrow function
2 participants
@junichi11 @tmysik