-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch FlatLaf JTabbedPane tab type to card. #6070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think it's better. In the output pane, having cards on the inner level did avoid the awkwardness of nesting two levels of tabs, but the cards were never very easy to read at a glance or in peripheral vision, especially when the output pane is not focused.
|
@mbien not sure I understand. This does make everything a similar card style. The earlier editor and view tab changes made them already this style. Do you mean accent coloured? The screenshots here don't show the overline colour when focused, because it's the unfocused tab selection that's hardest to see. We also have some weird focus issues in the options dialog, which doesn't help (find grabbing focus). |
ah right. I forgot that "sort opened document list by project" is swapping the tabs around. I thought we merged this #4948 :) |
ah, OK. We might want to merge the underline to overline switch from your PR pending further changes so at least when enabling multitabs it's somewhat consistent? |
I read through the discussion on the other PR and nobody said no to the tab rendering fix. So I suppose we can? Will prepare a PR. edit: see #6073 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it👍
Switch the FlatLaf tab type for standard JTabbedPane to card (from underline). Also add some top inset as that's necessary in a few places.
I've been running with this configured in local UI properties for months now. I find the underline tab type, particularly when unfocused, difficult to discern which tab is active. This seems to fit better with the editor / view tab changes too. Thought I'd open this as a potential default change ...