Allow to re-enter username and password #6057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to database fails
thurka
added
LSP
sdedic
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In context of LSP, when DB connection has incorrect username password, the user does not have a way to correct it. This PR tries to fix this problem and allows user to fill in new username and password, when connection fails. The same functionality was already available in netbeans, but VSCode integration (via LSP) just displayed the error dialog with exception and that's it. The LSP implenetation uses already established
headlessvariable to distinguish GUI and LSP part. Common functionality of getting username/password was extracted toCredentialsabstract class, with two implementations. One for LSP (CredetialsLine), which usesNotifyDescriptor.ComposedInputand the second one (CredetialsUI) for Swing UI.