Cleanup redundant cast warnings.. #5992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a result of much of the warning cleanup work I've done over the past couple of years, the redundant cast warnings start happening more fequently. [repeat] /home/bwalker/src/netbeans/platform/core.multitabs/src/org/netbeans/core/multitabs/impl/ButtonPopupSwitcher.java:344: warning: [cast] redundant cast to Item [repeat] final Item item = ( Item ) pTable.getSelectedItem(); [repeat] ^ This works reduces those warnings.
|
hi @BradWalker. PRs like this one here do always require the
ci:all-tests
more info on how CI works is on the wiki |
|
Thanks for the feedback/pointer. I wasn't aware of this. |
|
no worries brad. Also, restarting existing workflows won't take changes in labels into account unfortunately. We have a secret button which forces a new workflow though which I will now use :) |
matthiasblaesing
approved these changes
May 26, 2023
Hey @matthiasblaesing , I'm getting ready to clean up the few remaining calls to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of much of the warning cleanup work I've done over the past couple of years, the redundant cast warnings start happening more fequently.
This works reduces those warnings.