use SMO service for class name and SHA1 queries. #5984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 24, 2023
mbien
added
the
ci:dev-build
lbownik
reviewed
May 24, 2023
java/maven.indexer/src/org/netbeans/modules/maven/indexer/NexusRepositoryIndexerImpl.java
Outdated
Show resolved
Hide resolved
mbien
force-pushed
the
smo-augmented-index
branch
from
5277dc4 to
85b652e
Compare
mbien
force-pushed
the
smo-augmented-index
branch
from
85b652e to
d505314
Compare
|
looks like the search service had a bad day yesterday, the latency is better today. This is the |
mbien
force-pushed
the
smo-augmented-index
branch
from
d505314 to
dc314ca
Compare
java/maven.indexer/src/org/netbeans/modules/maven/indexer/CompositeResult.java
Show resolved
Hide resolved
- the remote index does not contain class name information anymore - sha1 queries are rarely used and contribute to index size, which makes them a good candidate for SMO too - SMO allows us to use a search service for selected queries SearchDependencyUI window update. - 'local search' checkbox to limit search to local repos - move search-in-progress marker to top of the list - other minor fixes (labels/resizing etc) - code renovation / deprecation fixes
mbien
force-pushed
the
smo-augmented-index
branch
from
dc314ca to
950911d
Compare
matthiasblaesing
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service https://github.com/apache/maven-indexer/tree/master/search-backend-smo (search maven org)
SearchDependencyUI window update.
sha1 query latency is fairly usable, here is the nbm wizard trying to resolve dependencies:
classname search can result in really bad latency, here a search for
StringUtilswhich collects 10 pages (which I set as maximum for now):FQ class names are not much better:
how to test:
open/create maven project, type some class name, use the hint to do a maven search. Results should contain both central and local entries. Should work for simple class names and fully qualified class names.
I am not sure how useful the sha1 query actually is, since features like attach src/doc do seem to work even with indexing disabled since it uses GAV. The local repo index does also contain hash information which means that as soon the project is primed, the local index could be used for it.
https://github.com/search?q=repo%3Aapache%2Fnetbeans+findBySHA1&type=code
please note that the
Dependencies -> Add Dependency...window does use a different code path (genericfindquery with arbitrary fields). Going to update that one some time later.