Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update external batik lib from 1.14 to 1.16. #5982

Merged
merged 1 commit into from
May 31, 2023

Conversation

Chris2011
Copy link
Contributor

As official mentioned 1.15 and 1.16 are just bugfixes. I just updated the version of it and will test whether everything is still fine or not.

@Chris2011 Chris2011 added the ci:all-tests [ci] enable all tests label May 23, 2023
@Chris2011 Chris2011 marked this pull request as draft May 23, 2023 17:51
@mbien mbien added the Upgrade Library Library (Dependency) Upgrade label May 23, 2023
@Chris2011 Chris2011 marked this pull request as ready for review May 23, 2023 20:34
@mbien mbien added this to the NB19 milestone May 24, 2023
Copy link
Member

@sdedic sdedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, thanks.

@sdedic sdedic requested a review from eirikbakke May 24, 2023 06:53
@ebarboni
Copy link
Contributor

@Chris2011 I think xmlgraphics-common should be 2.7 for 1.16 batik bump this version from 1.15

Copy link
Contributor

@eirikbakke eirikbakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it compiles and there are no visible defects introduced in the SVG icons above the code editor, then all is good. Thanks for the PR!

@Chris2011
Copy link
Contributor Author

Updated the requested xmlgraphics lib. I built it, ran it and it seems that it is working as before. If anyone else have smth to say, please do it. I will wait until next week and if there are no other concerns, I will merge it.

@Chris2011 Chris2011 force-pushed the feature/update-batik branch from 6c8cecf to 175da22 Compare May 30, 2023 19:29
As official mentioned 1.15 and 1.16 are just bugfixes.
Update external apache xmlgraphics-commons lib as requested.
@Chris2011 Chris2011 force-pushed the feature/update-batik branch from 175da22 to add4f64 Compare May 30, 2023 19:53
@Chris2011 Chris2011 merged commit 69e21cd into apache:master May 31, 2023
@Chris2011 Chris2011 deleted the feature/update-batik branch May 31, 2023 09:29
@ebarboni
Copy link
Contributor

@mbien
Copy link
Member

mbien commented May 31, 2023

@ebarboni what is the difference between the sig tests which run in github acitons and the sig tests which run on jenkins?

https://github.com/apache/netbeans/actions/runs/5125679254/jobs/9222051634
ran:

ant $OPTS verify-libs-and-licenses
+
ant $OPTS -quiet check-sigtests-release -Dfail.on.error=true
+
ant $OPTS -quiet gen-sigtests-release

@ebarboni
Copy link
Contributor

ebarboni commented Jun 1, 2023

I'm not 100% sure but it generate file over there **/sigtest/results/*.xml that are "junit" result.
On github action we maybe don't pay attention to the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:all-tests [ci] enable all tests Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants