-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update external batik lib from 1.14 to 1.16. #5982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK, thanks.
@Chris2011 I think xmlgraphics-common should be 2.7 for 1.16 batik bump this version from 1.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it compiles and there are no visible defects introduced in the SVG icons above the code editor, then all is good. Thanks for the PR!
Updated the requested xmlgraphics lib. I built it, ran it and it seems that it is working as before. If anyone else have smth to say, please do it. I will wait until next week and if there are no other concerns, I will merge it. |
6c8cecf
to
175da22
Compare
As official mentioned 1.15 and 1.16 are just bugfixes. Update external apache xmlgraphics-commons lib as requested.
175da22
to
add4f64
Compare
The sig test build is issuing warning. (was the case for 1.14 also) What would be a good way to clear this ? |
@ebarboni what is the difference between the sig tests which run in github acitons and the sig tests which run on jenkins? https://github.com/apache/netbeans/actions/runs/5125679254/jobs/9222051634
|
I'm not 100% sure but it generate file over there **/sigtest/results/*.xml that are "junit" result. |
As official mentioned 1.15 and 1.16 are just bugfixes. I just updated the version of it and will test whether everything is still fine or not.