-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace jakartaee archetype #5969
Draft
asbachb
wants to merge
7
commits into
apache:master
Choose a base branch
from
asbachb:replace-jakartaee-archetype
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be packaged as war as well
Now only one archetype is used instead of one per Jakarta EE version. The new archetype also generates projects which can be compiled with Java 17. Fixes apache#4552
… on used jdk Usually an application server will use Java LTS release to run on.
Contributed archetype: https://github.com/apache/netbeans-mavenutils-archetypes Waiting for publish to maven central. |
@ebarboni Could you line out what needs to be done in order to get the artifact to maven central? |
sorry for late response, we only have to vote on it and once accepted it will be propagated to central |
moving to NB20 |
@asbachb artifact is out and present on central |
This still active / relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to replace the used archetypes used to generate Jakarta EE projects which a new one which should be managed within the NetBeans project.
Instead of using one archetype per Jakarta EE version there's just one configured via system properties.
In addition the newly generated projects are able to be compiled with Java 17 (see #4552 )
Before this branch can be merged the archetype needs to be migrated to NetBeans project somehow: https://github.com/asbachb/jakartaee-war-archetype/tree/netbeans-adjustments