Navigator Support for HCL Files #5954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
I added a few inline comments.
What would be good is addition of unittests. I come from the CSS/JS side and it is totally helpful there, that there are tests, that just dump the detected structure and compare with the known good result. One problem that would most probably have been caught if there would have been a structure dump is the broken offset detection in (ASTBuilderListener).
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/HCLStructureItem.java
Outdated
Show resolved
Hide resolved
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/HCLStructureItem.java
Outdated
Show resolved
Hide resolved
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/ast/ASTBuilderListener.java
Outdated
Show resolved
Hide resolved
|
@matthiasblaesing Thank you for the insightful review! |
|
The red underlines are coming from the Lexer. Somehow I assigned the wrong coloring to the template content. Fixed in the last commit. Thanks for pointing that out! |
matthiasblaesing
approved these changes
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, this one is a bit more than the Navogator.
The AST is kind of ready till Attribute level. Beyond that there is the HCL Expression sub-language which AST still has to be done.
That makes possible to implement the structure scanner part for Navigator.
I've realized that the HCL Expression language can be parsed by the HCL parser itself, no need to generate a separate HCLExpressionParser. That would just duplicate a lot of internal context classes, and so it would needed a duplicate implementation of the expression AST builder.
I plan to remove the Terraform specific Lexer in the future, as that is a duplicate + small addition to the HCLLexer. That is used in the basic syntax Highlight only. It would be better to replace that with parser assisted depending on HCL language flavors.