bump delete-artifact action to v2 to be node 16 compatible. #5927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might want to run this one through delivery? There's a chance we could still be requiring testing there by that date. |
+ updated git ignore to ignore all private folders by default
yep. Wanted to test it on master first since delivery is broken. Will rebase if it works as expected. edit: it worked, no action related warnings anymore, see going to rebase and retarget to delivery |
mbien
force-pushed
the
ci-update-delete-action
branch
from
2fffd07 to
5ce63e9
Compare
|
@neilcsmith-net done, points at delivery now |
|
Thanks! And understand about delivery being broken - makes sense - hopefully can merge the fix asap, and then get other pending PRs in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github will switch everything to Node 16 on the 18th of May:
https://github.blog/changelog/2023-05-04-github-actions-all-actions-will-run-on-node16-instead-of-node12/
delete-artifact is the last remaining action which we haven't updated yet. We access the action via a git submodule since it is third-party. Other actions were bumped in #4770 and #5376
after that we shouldn't see any warnings of this kind anymore: