Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some of our exclusion for rat #5884

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Fix some of our exclusion for rat #5884

merged 1 commit into from
Jun 27, 2023

Conversation

ebarboni
Copy link
Contributor

Once Apache NetBeans is build you cannot use ant rat without license issue as some of generated code is not excluded.
On the maven plugin it's possible to exclude according to .gitignore but I did'nt succeed with ant.
Not sure the approach is correct but here is a fix.

ignore the following=>
generated code from ANTLR
in hcl languages
build artefacts
.gradle cache

Added a Header
missing header was detected on a test file in java.lsp

Maybe the jenkins jobs [1] could be patched to do a ant build before a ant rat verify-libs-and-licenses so we could anticipate the missing rules in rat file.

[1]https://ci-builds.apache.org/job/Netbeans/job/netbeans-license/

Copy link
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Although the important thing is that rat passes on the sources before a build. Having it still pass after a build is useful, but not essential IMO.

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

@mbien mbien added the build label May 9, 2023
@mbien mbien added this to the NB19 milestone May 9, 2023
@ebarboni ebarboni merged commit cfb7187 into apache:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants