Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SystemOpenAction dynamic in main menu #5870

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

neilcsmith-net
Copy link
Member

Rewrite the Open in System action with lookup listening so that it works dynamically with global context.

Now that SystemOpenAction is included in the main Tools menu ( #5770 ), the fact that the action doesn't enable and disable with the global context is very visible. When any item that is not a file is selected (service, pom navigator, etc.) the action remains enabled but non-operational. These changes ensure the action only appears when applicable.

@neilcsmith-net neilcsmith-net added this to the NB18 milestone Apr 21, 2023
@neilcsmith-net neilcsmith-net requested a review from mbien April 21, 2023 17:03
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@neilcsmith-net neilcsmith-net merged commit 84b94c9 into apache:delivery Apr 24, 2023
@neilcsmith-net neilcsmith-net deleted the global-system-open branch January 16, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants