HCL fix compound expression grammar #5854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkishalmi
requested review from
mbien,
vieiro,
matthiasblaesing and
neilcsmith-net
vieiro
approved these changes
Apr 20, 2023
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/grammar/g4/HCLExpressionParser.g4
Outdated
Show resolved
Hide resolved
|
Might be not the final expression Grammar, but seems to be good enough. |
Great job. Changes look great to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there is a bug in the HCL Grammar spec: hashicorp/hcl#553
According to the spec an
operationonly can happen betweenExprTerm-s notExpression-s making the following assignment invalid:This change moves the operations to the expression level, as ANTLR4 cannot handle indirect recursions, I had to move the operation rules to the expression level. I do not know if I took the left/right association directives right. That would only affect the ParserTree then the AST build up, though at the moment we do not use those that deep.