Fix HCL Lexer heredoc error on trailing space. #5846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lkishalmi can you rebase this to delivery? Since 19 has already branched. |
|
Yeah, I meant that. The commit was branched from delivery, forgot to set that on the PR. Thanks! |
mbien
approved these changes
Apr 18, 2023
|
@lkishalmi please leave us to handle merges to delivery, thanks! We open and close merge windows amongst the release team or we get tied up in knots. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last commits on HCL heredoc handling introduced a bug, that it could not determine the tokens right if the heredoc had trailing spaces, as checks for NewLine shall be the part of the loop not just once before.