basic auto completion for maven version properties. #5823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
commented
Apr 13, 2023
Comment on lines
471
to
472
| // version property completion | ||
| if (path.startsWith("/project/properties/") && path.indexOf("/", 20) == -1) { |
There was a problem hiding this comment.
this should make it hopefully fairly safe for inclusion. The code path is guarded by the xpath (basically), so it doesn't affect any other completion code.
There was a problem hiding this comment.
Nitpick: I would store the string to variable/constant, then would use length() or leave a comment for 20. I would add // NOI18N if possible.
mbien
added
the
ci:dev-build
mbien
force-pushed
the
maven-version-property-completion
branch
from
55f8cc9 to
15e1fbc
Compare
matthiasblaesing
approved these changes
Apr 14, 2023
It is somewhat common to use properties for artifact versions, esp when several artifacts share the same version. This implements basic auto completion for properties which are used as version field. In contrast to hints, completion is implemented in the grammar and doesn't have the full context. This will only take properties into account which are in the same pom file as their usage.
mbien
force-pushed
the
maven-version-property-completion
branch
from
15e1fbc to
34cecee
Compare
|
thanks for the reviews. added going to merge once green again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is somewhat common to use properties for artifact versions, esp when several artifacts share the same version.
This implements basic auto completion for properties which are used as version field.
In contrast to hints, completion is implemented in the grammar and doesn't have the full context. This will only take properties into account which are in the same pom file as their usage.